Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h265_params 対応 #486

Merged
merged 4 commits into from
Dec 5, 2023
Merged

h265_params 対応 #486

merged 4 commits into from
Dec 5, 2023

Conversation

tnamao
Copy link
Contributor

@tnamao tnamao commented Dec 4, 2023

変更履歴

  • [ADD] h265_params のフォームを追加する

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6516ff
Status: ✅  Deploy successful!
Preview URL: https://51ddbc7d.sora-devtools.pages.dev
Branch Preview URL: https://feature-h265-params.sora-devtools.pages.dev

View logs

@voluntas
Copy link
Member

voluntas commented Dec 5, 2023

@miosakuma 動作確認お願いできますか（払い出されることだけ確認したら、マージして貰っておｋです）

@miosakuma
Copy link
Contributor

miosakuma commented Dec 5, 2023 •
edited
Loading

以下、確認しました。問題ありませんでした。

  • シグナリングの正しい箇所に h265_params が設定されることを確認しました
    "video": {
      "codec_type": "H265",
      "h265_params": {
        "level_id": 91
      }
    },
  • copy URL ボタンで h265_params の値が引き継がれることを確認しました

@miosakuma miosakuma merged commit 6a4430e into develop Dec 5, 2023
2 checks passed
@miosakuma miosakuma deleted the feature/h265-params branch December 5, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnamao @voluntas @miosakuma